JP-2303: Allow user input for resample weight_type param #6406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdavies-st
approved these changes
Oct 21, 2021
If you know of any appropriate escape sequence for python logging to do that, I'm happy to implement! Perhaps along with an audio snippet of "Danger Will Robinson!" |
|
CI failures appear to be unrelated (tweakreg unit tests). Merging. |
nden
pushed a commit
to nden/jwst
that referenced
this pull request
Nov 2, 2021
…ope#6406) * JP-2303: All user input for resample weight_type param * Fix unit test and add change log entry
nden
pushed a commit
to nden/jwst
that referenced
this pull request
Nov 2, 2021
…ope#6406) * JP-2303: All user input for resample weight_type param * Fix unit test and add change log entry
loicalbert
pushed a commit
to talensgj/jwst
that referenced
this pull request
Nov 5, 2021
…ope#6406) * JP-2303: All user input for resample weight_type param * Fix unit test and add change log entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6401
Resolves JP-2303
Description
This PR allows for user override of the resample step
weight_typeparameter. The param is defined to allow selections ofivmandexptime(withivmas the default), but theivmvalue was hardwired in calls to lower-level functions, hence ignoring the choice ofexptimewhen selected. This change allows for the selection specified when the step is called to be passed down. It also warns the user that the choice ofexptimewill result in incorrect error propagation.Checklist