8000 Fix p_grating schema pattern and RegionsModel ndarray validation by eslavich · Pull Request #6333 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix p_grating schema pattern and RegionsModel ndarray validation #6333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2021
Merged

Fix p_grating schema pattern and RegionsModel ndarray validation #6333

merged 2 commits into from
Oct 12, 2021

Conversation

eslavich
Copy link
Contributor
@eslavich eslavich commented Sep 8, 2021 •
edited by jdavies-st
Loading

Description

This PR addresses two datamodel validation issues:

  • Removes extra / from the regex pattern for p_grating
  • Adds NDArrayType to the list of valid types for RegionsModel.regions so that models constructed from ASDF files will validate

Checklist

  • Tests
  • Documentation
  • Change log
  • Milestone
  • Label(s)

@codecov
Copy link
codecov bot commented Sep 8, 2021 •
edited
Loading

Codecov Report

Merging #6333 (105ce83) into master (b8f9c7d) will decrease coverage by 3.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6333      +/-   ##
==========================================
- Coverage   77.73%   74.29%   -3.45%     
==========================================
  Files         408      410       +2     
  Lines       34892    38806    +3914     
==========================================
+ Hits        27124    28830    +1706     
- Misses       7768     9976    +2208
Flag Coverage Δ *Carryforward flag
nightly 78.29% <50.00%> (+0.55%) ⬆️ Carriedforward from 436921b
unit 56.38% <100.00%> (?)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/datamodels/wcs_ref_models.py 88.59% <100.00%> (+11.73%) ⬆️
...ter_background/master_background_nrs_slits_step.py 18.18% <0.00%> (-70.71%) ⬇️
jwst/white_light/white_light_step.py 47.36% <0.00%> (-37.25%) ⬇️
jwst/cube_build/blot_cube_build.py 68.89% <0.00%> (-30.03%) ⬇️
jwst/regtest/conftest.py 58.36% <0.00%> (-29.14%) ⬇️
jwst/coron/klip_step.py 72.72% <0.00%> (-27.28%) ⬇️
jwst/ami/ami_normalize_step.py 72.72% <0.00%> (-27.28%) ⬇️
jwst/outlier_detection/outlier_detection_ifu.py 64.84% <0.00%> (-26.43%) ⬇️
jwst/refpix/irs2_subtract_reference.py 58.63% <0.00%> (-25.63%) ⬇️
jwst/assign_wcs/niriss.py 53.54% <0.00%> (-25.17%) ⬇️
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8f9c7d...105ce83. Read the comment docs.

@eslavich eslavich added this to the Build 7.9 milestone Sep 9, 2021
@eslavich eslavich requested a review from hbushouse September 9, 2021 13:04
nden
nden requested changes Oct 11, 2021
View reviewed changes
Copy link
Collaborator
@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs. rebase.

@nden
Copy link
Collaborator
nden commented Oct 11, 2021

I removed the approval only because it needs rebasing. Looks good other than that.

hbushouse
hbushouse approved these changes Oct 12, 2021
View reviewed changes
Copy link
Collaborator
@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (modulo a rebase)

@stscieisenhamer stscieisenhamer requested a review from nden October 12, 2021 12:54
@stscieisenhamer stscieisenhamer merged commit 602b6c9 into spacetelescope:master Oct 12, 2021
loicalbert pushed a commit to talensgj/jwst that referenced this pull request Nov 5, 2021
@eslavich @stscieisenhamer @loicalbert
Fix p_grating schema pattern and RegionsModel ndarray validation (spa…
693fd3e 
…cetelescope#6333)

Co-authored-by: Jonathan Eisenhamer <eisenhamer@stsci.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nden nden nden approved these changes

@stscieisenhamer stscieisenhamer stscieisenhamer approved these changes

@hbushouse hbushouse hbushouse approved these changes

Assignees
No one assigned
Labels
bug datamodels
Projects
None yet
Milestone
Build 7.9
Development

Successfully merging this pull request may close these issues.
4 participants
@eslavich @nden @stscieisenhamer @hbushouse
0