8000 JP-2224: Fixed a bug in flatfield for brightobj mode by stscirij · Pull Request #6332 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-2224: Fixed a bug in flatfield for brightobj mode #6332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2021
Merged

JP-2224: Fixed a bug in flatfield for brightobj mode #6332

merged 2 commits into from
Sep 9, 2021

Conversation

stscirij
Copy link
Contributor
@stscirij stscirij commented Sep 8, 2021 •
edited by hbushouse
Loading

Closes #6268

Resolves JP-2224

Description

This PR addresses JP-2224. The cutout of the S-flat component of the flatfield was calculated incorrectly by not including the slit offset as well as the subarray offset.

Checklist

  • Tests
  • Documentation
  • Change log
  • Milestone
  • Label(s)

@stscirij stscirij requested a review from hbushouse September 8, 2021 19:28
@codecov
Copy link
codecov bot commented Sep 8, 2021 •
edited
Loading

Codecov Report

Merging #6332 (53e8f8f) into master (f86c126) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6332   +/-   ##
=======================================
  Coverage   76.97%   76.97%           
=======================================
  Files         402      402           
  Lines       35710    35710           
=======================================
  Hits        27486    27486           
  Misses       8224     8224
Flag Coverage Δ *Carryforward flag
nightly 78.29% <100.00%> (ø) Carriedforward from f86c126
unit 56.87% <0.00%> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/flatfield/flat_field.py 82.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f86c126...53e8f8f. Read the comment docs.

@hbushouse hbushouse added this to the Build 7.9 milestone Sep 9, 2021
hbushouse
hbushouse approved these changes Sep 9, 2021
View reviewed changes
Copy link
Collaborator
@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. And I see that the change is confined to a routine that's only used for BrightObj mode, so that answers my question as to whether it would also affect other modes like the generic fixed-slit and MOS.

@hbushouse hbushouse merged commit 7a6140e into spacetelescope:master Sep 9, 2021
@stscijgbot-jp stscijgbot-jp mentioned this pull request Sep 13, 2021
Closed
loicalbert pushed a commit to talensgj/jwst that referenced this pull request Nov 5, 2021
@stscirij @loicalbert
JP-2224: Fixed a bug in flatfield for brightobj mode (spacetelescope#…
85d0dc4 
…6332)

* Changed pixel offsets for brightobj mode
Addresses spacetelescope#6268

* Changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbushouse hbushouse hbushouse approved these changes

Assignees
No one assigned
Labels
bug flatfield NIRSPEC
Projects
None yet
Milestone
Build 7.9
Development

Successfully merging this pull request may close these issues.

NIRSpec - spec2 flat field: calculated flat fails validation test for BOTS data NRS1 detector
2 participants
@stscirij @hbushouse
0