8000 JP-2096: Fix c code for cube_build by jemorrison · Pull Request #6255 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-2096: Fix c code for cube_build #6255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2021
Merged

JP-2096: Fix c code for cube_build #6255

merged 1 commit into from
Jul 29, 2021

Conversation

jemorrison
Copy link
Collaborator
@jemorrison jemorrison commented Jul 29, 2021 •
edited by hbushouse
Loading

Fix some of the C routines merged in #6093

@jemorrison jemorrison changed the title define all varibles in c code at the top Fix c code for cube_build Jul 29, 2021
@jemorrison
Copy link
Collaborator Author

@nden
This should do it. I hope

@codecov
Copy link
codecov bot commented Jul 29, 2021 •
edited
Loading

Codecov Report

Merging #6255 (e3a4913) into master (477d8b0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6255   +/-   ##
=======================================
  Coverage   75.43%   75.43%           
=======================================
  Files         405      405           
  Lines       36057    36057           
=======================================
  Hits        27199    27199           
  Misses       8858     8858
Flag Coverage Δ *Carryforward flag
nightly 77.81% <ø> (ø) Carriedforward from 477d8b0
unit 56.77% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 477d8b0...e3a4913. Read the comment docs.

@jemorrison
Copy link
Collaborator Author

@eslavich Do you know why I am having a failed test with pyargs. It seemed like that last time I did a PR I also got that error.

@nden nden merged commit 2ea876f into spacetelescope:master Jul 29, 2021
@nden nden added this to the Build 7.9 milestone Jul 29, 2021
@jemorrison jemorrison deleted the fix_code branch August 2, 2021 17:55
@jdavies-st jdavies-st modified the milestones: Build 7.9, Build 7.8.2 Sep 2, 2021
@jdavies-st jdavies-st changed the title Fix c code for cube_build JP-2096: Fix c code for cube_build Sep 2, 2021
jdavies-st pushed a commit that referenced this pull request Sep 3, 2021
@jemorrison @jdavies-st
define all varibles in c code at the top (#6255)
f860d95 
(cherry picked from commit 2ea876f)
loicalbert pushed a commit to talensgj/jwst that referenced this pull request Nov 5, 2021
@jemorrison @loicalbert
define all varibles in c code at the top (spacetelescope#6255)
234f39e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nden nden nden approved these changes

Assignees
No one assigned
Labels
cube_build
Projects
None yet
Milestone
Build 7.8.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jemorrison @nden @jdavies-st
0