Open specwcs reffile with context manager #6160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6160 +/- ##
=======================================
Coverage 77.15% 77.15%
=======================================
Files 402 402
Lines 34369 34436 +67
=======================================
+ Hits 26517 26569 +52
- Misses 7852 7867 +15
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
jdavies-st
commented
Jun 21, 2021
Comment on lines
-150
to
-153
| try: | ||
| velosys = input_model.meta.wcsinfo.velosys | ||
| except AttributeError: | ||
| pass |
There was a problem hiding this comment.
No need for a try/except block here as it will never fail to have this attribute since it is in the wcsinfo schema.
eslavich
reviewed
Jun 22, 2021
loicalbert
pushed a commit
to talensgj/jwst
that referenced
this pull request
Nov 5, 2021
* Open specwcs reffile with context manager * Update CHANGES.rst * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem we saw in a unit test where the
specwcsreffile was incompletely downloaded from CRDS and soasdf.open()failed. When it failed, it was not closed, as it never went through__exit__.Not sure if this is a problem with thewithcontext manager inasdf.open(), i.e. is heavy-lifting happening inAsdfFile.__init__that should be happening inAsdfFile.__enter__? Not sure.Regardless, in this case, as soon asasdf.open(file)was called, it opens it without using__enter__. Is this a bug or feature inasdf@eslavich ? Or just a small bug here.Separate issue filed in asdf-format/asdf#1006
Also cleaned up a try/except block below.
velosysis guaranteed to be an attribute as it is in the schema.Checklist