8000 HLA-1483: Remove the extraneous column from Point source Total catalog by mdlpstsci · Pull Request #2006 · spacetelescope/drizzlepac · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ < 8000 strong itemprop="name" class="mr-2 flex-self-stretch"> drizzlepac Public

HLA-1483: Remove the extraneous column from Point source Total catalog #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 1, 2025
Merged

HLA-1483: Remove the extraneous column from Point source Total catalog #2006

merged 3 commits into from
May 1, 2025

Conversation

mdlpstsci
Copy link
Collaborator

Resolves HLA-1483

Closes #

Removed the extra column in the Point source identification table when using DAOStarFinder or IRAFStarFinder. The extra column, daofind_mag, was added in Photutils 2.0. Ensure all returned tables from these "finders" are converted from QTable to Astropy Table. Modified the hap/test_svm_je281u.py PyTest to look for unexpected column.

Checklist for maintainers

  • added entry in CHANGELOG.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant label(s)

@mdlpstsci
Removed the extra column in the Point source identification table whe…
8d0a927 
…n using

DAOStarFinder or IRAFStarFinder.  The extra column, daofind_mag, was added in
Photutils 2.0.  Ensure all returned tables from these "finders" are converted
from QTable to Astropy Table.  Modified the hap/test_svm_je281u.py PyTest to
look for unexpected column.
@mdlpstsci mdlpstsci added bug jirahub-ignore Avoid linking to Jira labels Apr 30, 2025
@mdlpstsci mdlpstsci self-assigned this Apr 30, 2025
@mdlpstsci mdlpstsci requested a review from a team as a code owner April 30, 2025 21:22
@mdlpstsci mdlpstsci requested a review from s-goldman April 30, 2025 21:22
s-goldman
s-goldman approved these changes May 1, 2025
View reviewed changes
Copy link
Collaborator
@s-goldman s-goldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@mdlpstsci mdlpstsci merged commit 38e7773 into spacetelescope:main May 1, 2025
16 checks passed
s-goldman pushed a commit to s-goldman/drizzlepac that referenced this pull request May 6, 2025
@mdlpstsci @s-goldman
HLA-1483: Remove the extraneous column from Point source Total catalog (
0419fe0 
spacetelescope#2006)
s-goldman added a commit that referenced this pull request May 6, 2025
@s-goldman @mdlpstsci
Cherry-picking recent PRs #2006, #2007, #2009 onto release branch (#2012
3f2e491 
)

Co-authored-by: mdlpstsci <mdelapena@stsci.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-goldman s-goldman s-goldman approved these changes

Assignees

@mdlpstsci mdlpstsci

Labels
bug jirahub-ignore Avoid linking to Jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdlpstsci @s-goldman
0