[Backport M84] Backport #7654 and #7669 to m84 #7681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Changes I removed global `requestTimings: WeakMap<ClientRequest, RequestTimings>` map, as those objects by no means need to be stored globally. We can create them on the request level and pass downstream to the listeners. Then request/socket object will get destroyed those objects will be destroyed as well. In my opinion there is no need for listeners removal as listener callbacks will be garbage collected when request/socket object will be removed (as long as we don't also put it in global disposables array as before). ## Test plan 1. Disable network connection 3. Open `Cody: Network` output channel 4. Do some cody actions (e.g. try to use chat) 5. You should see some network errors logged (no change in behaviour):  (cherry picked from commit e8258b2)
## Changes Looks like in case of the socket we cannot rely on the automatic cleanup upon the object destruction, because we are reusing the sockets. That is why we need to manually remove listeners when the socket is closed. ## Test plan 1. Play with Cody for a while (1 min of editing a text file is more than enough) 2. Search log for "leak detected" - there should be no leaks or too many listener warnings. <!-- Required. See https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles. --> (cherry picked from commit 49cdd04)
hitesh-1997
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of 7654 and 7669 to M84
CC @sourcegraph/release
Test plan
As in:
#7654
#7669