fix(telemetry): remove telemetry option from VSCode #7636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Telemetry can only be disabled for non-Sourcegraph.com / Workspaces instances. This commit updates the check to ensure telemetry is only disabled when the instance is not a dotcom or a workspace instance. ## Test Plan Data team to test
akalia25
reviewed
Mar 31, 2025
Co-authored-by: Aditya Kalia <32119652+akalia25@users.noreply.github.com>
akalia25
reviewed
Mar 31, 2025
vscode/src/services/telemetry-v2.ts
Outdated
Comment on lines
40
to
43
| // Telemetry Collection Policy: | ||
| // - Sourcegraph.com users (Free & Pro): Telemetry collection is mandatory and always enabled. | ||
| // - Workspace Users (Enterprise Starter): Telemetry collection is mandatory and always enabled. | ||
| // - Enterprise Customer Users: Have the option to disable telemetry collection |
There was a problem hiding this comment.
based on this https://sourcegraph.slack.com/archives/C08KHA6F94N/p1743439620212869?thread_ts=1743398116.650869&cid=C08KHA6F94N we may need to update this.
The `cody.telemetry.level` setting is removed from the VS Code configuration. Telemetry is now enabled by default for all users, except for those on enterprise
graceshih-sg
approved these changes
Apr 4, 2025
|
Hey @ichim-david, I tested this change with our internal sourcegraph workspace and was able to disable telemetry, 🤔 are you also experiencing this? |
|
working as expected! The issue was with my dev environment 🤦! Thanks @ichim-david for the change! |
akalia25
approved these changes
Apr 4, 2025
- this avoids having to fix package.json after a simple save
ghost
reviewed
Apr 4, 2025
The telemetry level check is removed. Telemetry is now enabled by default for all users
… warning This commit suppresses the N-API callback uncaught exception warning by setting the `NODE_NO_WARNINGS` environment variable to '1'. This prevents the warning from being displayed during integration tests. See https://nodejs.org/api/n-api.html#n_api_uncaught_exceptions for more information.
graceshih-sg
approved these changes
Apr 4, 2025
graceshih-sg
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed telemetry option from VSCode
Test Plan
Data team to test and confirm on the telemetry side for all supported Cody clients