fix/guardrails: In enforced mode, hide smart apply, etc. actions until attribution complete #7579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
approved these changes
Mar 27, 2025
abeatrix
pushed a commit
that referenced
this pull request
Mar 27, 2025
…c. actions until attribution complete (#7581) When Guardrails is in "enforced" mode, we want to prevent the user from using code until an attribution check is complete. Hide the action buttons until it is OK to show the code. For Guardrails "permissive" mode, or no Guardrails, `showCode` is always `true` and we will show the action buttons as soon as the code is complete. This also bumps the timeout for Guardrails attribution requests. These requests can easily take 20s+ for long code blocks. Fixes CODY-5552, CODY-5551 ## Test plan Tested manually: 1. Set up an instance with `"attribution.enabled": true, "attribution.mode": "enforced"` and connect to it. 2. Generate more than 10 lines of code. 3. Check that the action buttons do not appear while "Checking Guardrails" <br> Backport df3abdd from #7579 Co-authored-by: Dominic Cooney <dominic.cooney@sourcegraph.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Guardrails is in "enforced" mode, we want to prevent the user from using code until an attribution check is complete. Hide the action buttons until it is OK to show the code.
For Guardrails "permissive" mode, or no Guardrails,
showCodeis alwaystrueand we will show the action buttons as soon as the code is complete.This also bumps the timeout for Guardrails attribution requests. These requests can easily take 20s+ for long code blocks.
Fixes CODY-5552, CODY-5551
Test plan
Tested manually:
"attribution.enabled": true, "attribution.mode": "enforced"and connect to it.