8000 Fix CI on main by ProKil · Pull Request #167 · sotopia-lab/sotopia · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix CI on main #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2024
Merged

Fix CI on main #167

merged 2 commits into from
Aug 11, 2024

Conversation

ProKil
Copy link
Member
@ProKil ProKil commented Aug 11, 2024

Current main branch has a weird mypy error. This PR tries to solve it.

📑 Description

  • Remove poetry lock to make sure the CI uses the locked versions
  • Remove human_eval folder since it is not part of the core package. We can add it to other repos.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed
  • Branch name follows type/descript (e.g. feature/add-llm-agents)
  • Ready for code review

ℹ Additional Information

Copy link
codecov bot commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.00%. Comparing base (4dffcdd) to head (c656521).

@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   60.21%   61.00%   +0.78%     
==========================================
  Files          55       55              
  Lines        2800     2800              
==========================================
+ Hits         1686     1708      +22     
+ Misses       1114     1092      -22     

see 3 files with indirect coverage changes

@ProKil ProKil requested a review from XuhuiZhou August 11, 2024 02:37
@ProKil
Copy link
Member Author
ProKil commented Aug 11, 2024

@XuhuiZhou Please review and merge PR to fix the current mypy error on main.

@XuhuiZhou XuhuiZhou merged commit 145bb23 into main Aug 11, 2024
8 checks passed
@ProKil ProKil deleted the bug/fix-ci-on-mai branch August 14, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0