Adding Android support #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #658 +/- ##
=======================================
Coverage 80.69% 80.69%
=======================================
Files 83 83
Lines 7373 7373
=======================================
Hits 5950 5950
Misses 1423 1423 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adam-fowler
approved these changes
May 10, 2025
|
thank you for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
The goal of this pull request is to add Android support to soto-core.
The following changes were verified on the swift-6.1 toolchain built for
Android.
Implementation Details 🚧
soto-core should work flawlessly against an android swift toolchain
(tested with version 6.1) with the same limitations and context as the
current support on Linux + Windows.
Testing Details 🔍
No new unit tests were added.
tested on android api level 30