8000 Remove high IR zone check by jeanconn · Pull Request #450 · sot/starcheck · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove high IR zone check #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

Remove high IR zone check #450

merged 1 commit into from
Mar 7, 2025

Conversation

jeanconn
Copy link
Contributor
@jeanconn jeanconn commented Mar 7, 2025 •
edited
Loading

Description

Remove check for NMM in the high IR zone as this is no longer needed.

Interface impacts

Testing

Unit tests

  • Linux
ska3-jeanconn-fido> git rev-parse HEAD
ae6d9db81c04bb04f8f4ee364fc7c0c5cb35874c
ska3-jeanconn-fido> pytest
================================================= test session starts ==================================================
platform linux -- Python 3.12.8, pytest-8.3.4, pluggy-1.5.0
rootdir: /proj/sot/ska/jeanproj/git
configfile: pytest.ini
plugins: anyio-4.7.0, timeout-2.3.1
collected 14 items                                                                                                     

starcheck/tests/test_state_checks.py .............                                                               [ 92%]
starcheck/tests/test_utils.py .                                                                                  [100%]

================================================= 14 passed in 21.42s

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

Given that this does not change logic or formatting besides just removing a recently-added section of the report, I just ran one week as a functional and regression test and confirmed that the check text was removed, there were no new warnings or failures, and the diffs against output from master (not flight) are as expected.

Diff https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck/starcheck-pr450/diff.html

New output https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck/starcheck-pr450/mar1025a_test.html

@jeanconn jeanconn marked this pull request as ready for review March 7, 2025 00:23
@jeanconn jeanconn requested review from Copilot and taldcroft March 7, 2025 00:23
Copilot
Copilot AI reviewed Mar 7, 2025
View reviewed changes
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR removes the check for the high IR zone as it is no longer needed.

  • Removed the ir_zone_ok function from starcheck/state_checks.py.
  • Deleted the associated make_ir_check_report function and its import from starcheck/utils.py.

Reviewed Changes

File Description
starcheck/state_checks.py Removed the IR zone check function (ir_zone_ok).
starcheck/utils.py Removed IR zone check report logic and its usage.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@jeanconn jeanconn requested a review from javierggt March 7, 2025 00:23
taldcroft
taldcroft approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member
@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jeanconn jeanconn merged commit 66c6111 into master Mar 7, 2025
@jeanconn jeanconn deleted the remove-ir-zone branch March 7, 2025 12:53
This was referenced Mar 18, 2025
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@taldcroft taldcroft taldcroft approved these changes

@javierggt javierggt Awaiting requested review from javierggt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeanconn @taldcroft
0