8000 Add notebook to make quick regress scripts by jeanconn · Pull Request #440 · sot/starcheck · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add notebook to make quick regress scripts #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2024
Merged

Add notebook to make quick regress scripts #440

merged 1 commit into from
Mar 14, 2024

Conversation

jeanconn
Copy link
Contributor

Description

Add notebook to make quick regress scripts

Interface impacts

Testing

Irrelevant but.

Unit tests

  • Mac

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

@jeanconn jeanconn requested a review from javierggt February 27, 2024 19:56
@jeanconn jeanconn requested a review from taldcroft March 11, 2024 12:32
taldcroft
taldcroft approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member
@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The load name parsing code could be replaced by parse_cm.paths.parse_load_name. And related there is also kadi.commands.core.load_name_to_cxotime.

But for this purpose replicating code is fine.

@jeanconn jeanconn merged commit 994de53 into master Mar 14, 2024
@jeanconn jeanconn deleted the add-wip-regress-nb branch March 14, 2024 14:12
This was referenced Apr 17, 2024
Closed
Merged
@javierggt javierggt mentioned this pull request May 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taldcroft taldcroft taldcroft approved these changes

@javierggt javierggt Awaiting requested review from javierggt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeanconn @taldcroft
0