8000 Rename test so error isn't in the name by jeanconn · Pull Request #50 · sot/ska_helpers · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Rename test so error isn't in the name #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Rename test so error isn't in the name #50

merged 1 commit into from
Nov 1, 2023

Conversation

jeanconn
Copy link
Contributor

Description

Rename test so error isn't in the name

It is easier just to rename the test than to handle this in ska_testr where we are currently not passing integration tests on ska_helpers with:

'error' matched at test_unit.log:50 :: ../../../../../../../ska_testr/tests/test
_utils.py::test_convert_to_int_float_str_error PASSED

Interface impacts

Testing

Unit tests

  • Mac

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

@jeanconn jeanconn requested a review from javierggt October 25, 2023 17:07
@jeanconn jeanconn merged commit bee8099 into master Nov 1, 2023
@jeanconn jeanconn deleted the error_to_err branch November 1, 2023 17:30
@javierggt javierggt mentioned this pull request Dec 5, 2023
@javierggt javierggt mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0