Add include/exclude of fids by index/id #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
requested changes
Jul 27, 2020
taldcroft
approved these changes
Aug 3, 2020
|
This does not fix #208 but should be considered part of that work. |
taldcroft
added a commit
that referenced
this pull request
Sep 25, 2020
1 task
1 task
taldcroft
added a commit
that referenced
this pull request
Sep 25, 2020
Fix allowed_kwargs test after #331
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add include/exclude of fids by index/id
I went with the strategy of using the included or excluded ids to reduce the candidate fid sets at the beginning of the fid selection. If an impossible fid is requested, no candidates will remain and no fids will be selected. This seemed reasonable for the use cases (though may not work to manually select fid sets used in previous undercover observations with off-CCD fids).
Testing