8000 Add the list of obsids that are bad for trending to the project by jeanconn · Pull Request #80 · sot/mica · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add the list of obsids that are bad for trending to the project #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 1, 2020
Merged

Add the list of obsids that are bad for trending to the project #80

merged 4 commits into from
Oct 1, 2020

Conversation

jeanconn
Copy link
Contributor
@jeanconn jeanconn commented May 9, 2016

Add the list of obsids that are bad for trending to the project.

@jeanconn
Copy link
Contributor Author
jeanconn commented May 9, 2016

Not sure where this belongs, but this seems a better option than in the repo of starcheck data.

@jeanconn
Copy link
Contributor Author

If we want this someplace else or broken into categories or accessible with a tool we should do this, otherwise not sure what to do with this PR.

@javierggt
Copy link
Contributor

I'm ok with this. Remember I am adding a table to the agasc_supplement with OBSID info as well, but they are different things though.

@jeanconn
Copy link
Contributor Author

What's that table with OBSID going to look like again?

taldcroft
taldcroft approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member
@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@taldcroft
Copy link
Member

Actually, what is missing is sphinx documentation that this file exists and description of its contents.

@jeanconn
Copy link
Contributor Author

If we want this documented, can we merge #240 first?

@taldcroft
Copy link
Member

If we want this documented, can we merge #240 first?

Done.

@jeanconn
Copy link
Contributor Author

I'm not sure how to test the docs anymore though:

shiny-fido$ make html
sphinx-build -b html -d _build/doctrees   . _build/html
Running Sphinx v3.1.2
WARNING: html_static_path entry '_static' does not exist

Theme error:
no theme named 'bootstrap-ska' found (missing theme.conf?)
make: *** [html] Error 2

@taldcroft
Copy link
Member

@javierggt ??

@javierggt
Copy link
Contributor

ah, I just saw this. You can do:

python -m pip install git+https://github.com/sot/ska-sphinx-theme

@javierggt
Copy link
Contributor

If you prefer to add the theme some other way, I can do that.

@jeanconn
Copy link
Contributor Author

Thanks @javierggt! Should the theme be in its own or another conda package in shiny?

@javierggt
Copy link
Contributor

Whatever you prefer. I can add the meta.yaml in skare3.

@taldcroft
Copy link
Member

If there is a new dependency for building Ska package docs then it should definitely be in Ska conda to allow building docs locally.

@jeanconn jeanconn merged commit 59e17e2 into master Oct 1, 2020
@jeanconn jeanconn deleted the add_bad_obs branch October 1, 2020 16:16
@javierggt javierggt mentioned this pull request Nov 17, 2020
Merged
@javierggt javierggt mentioned this pull request Dec 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierggt javierggt javierggt approved these changes

@taldcroft taldcroft taldcroft approved these changes

Assignees
No one assigned
Labels
Ready for Final Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeanconn @javierggt @taldcroft
0