Make a target table product #264
Conversation
e31767d to
9d0438c
Compare
00afe92 to
f6a168a
Compare
26aeb1a to
8c4838a
Compare
| ============================= ================================================================ | ||
|
|
||
| The hdf5 in-kernel searches may be faster working with the table directly for some | ||
| operations. |
There was a problem hiding this comment.
Seems like it would be fairly trivial to include the Table.read_where args in this function. Then just include links to relevant docs like https://www.pytables.org/usersguide/condition_syntax.html and of course the read_where docstring. For the code here still use read unless one of those read_where args is not None.
There was a problem hiding this comment.
Sure. Seems fine but I note that including read_where seems to throw a bunch of these warnings
mica/archive/tests/test_target_table.py::test_write_read_table
/Users/jean/miniconda3/envs/ska3/lib/python3.8/site-packages/tables/path.py:155: NaturalNameWarning: object name is not a valid Python identifier: 'mon_max.mask'; it does not match the pattern ``^[a-zA-Z_][a-zA-Z0-9_]*$``; you will not be able to use natural naming to access this object; using ``getattr()`` will still work, though
check_attribute_name(name)
Not sure if we want to shut those up or ?
There was a problem hiding this comment.
Well never mind for now. Let's go for the incremental development and just get something in.
|
Let's lower-case all the column names. |
54a8f51 to
55812a3
Compare
| ============================= ================================================================ | ||
|
|
||
| The hdf5 in-kernel searches may be faster working with the table directly for some | ||
| operations. |
There was a problem hiding this comment.
Well never mind for now. Let's go for the incremental development and just get something in.
|
I'm not actually seeing which piece you are meaning for "never mind for now". Do you mean you want to pull out the |
|
I think messages got crossed up in threads. All good. |
Description
Make a target table product
Testing