8000 Add ACIS DPA power state and refactor validation using that state by taldcroft · Pull Request #358 · sot/kadi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add ACIS DPA power state and refactor validation using that state #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: states-derived-transitions
Choose a base branch
from
Open

Add ACIS DPA power state and refactor validation using that state #358

wants to merge 1 commit into from

Conversation

taldcroft
Copy link
8000 Member

Description

With #350, it is straightforward to add a DPA power computed state (dpa_power) by moving the calculation defined in #357 into a computed state. After that, the validation class becomes trivial since it depends only on an MSID and a single state value.

Requires

Interface impacts

Adds dpa_power commanded state.

Testing

Unit tests

  • Mac
(ska3) ➜  kadi git:(dpa-power-state) git rev-parse --short HEAD                              
3d8e363
(ska3) ➜  kadi git:(dpa-power-state) pytest
================================================== test session starts ==================================================
platform darwin -- Python 3.12.8, pytest-8.3.4, pluggy-1.5.0
rootdir: /Users/aldcroft/git
configfile: pytest.ini
plugins: anyio-4.7.0, timeout-2.3.1
collected 210 items                                                                                                     

kadi/commands/tests/test_commands.py ............................................................................ [ 36%]
......                                                                                                            [ 39%]
kadi/commands/tests/test_filter_events.py ..                                                                      [ 40%]
kadi/commands/tests/test_states.py .............................................x..........................       [ 74%]
kadi/commands/tests/test_validate.py ......................                                                       [ 84%]
kadi/tests/test_events.py ..........                                                                              [ 89%]
kadi/tests/test_occweb.py ......................                                                                  [100%]

====================================== 209 passed, 1 xfailed in 182.34s (0:03:02) =======================================

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

This gives the expected result.

python -m kadi.scripts.validate_states --state dpa_power

@taldcroft taldcroft requested a review from jzuhone May 28, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzuhone jzuhone jzuhone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taldcroft @jzuhone
0