8000 SHINY: remove all dependencies on Chandra.cmd_states and Ska.ParseCM by taldcroft · Pull Request #167 · sot/kadi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

SHINY: remove all dependencies on Chandra.cmd_states and Ska.ParseCM #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 30, 2020
Merged

SHINY: remove all dependencies on Chandra.cmd_states and Ska.ParseCM #167

merged 8 commits into from
Jun 30, 2020

Conversation

taldcroft
Copy link
Member

Description

Remove all dependencies on Chandra.cmd_states and Ska.ParseCM:

  • Copy a couple of functions into kadi
  • Generate regression test files if necessary (one-time operation) using Chandra.cmd_states, and subsequently just read the existing files.
  • Improve interpolate_states a bit since I was in there.

This makes the Ska.ParseCM FutureWarning go away.

Testing

  • Passes unit tests on MacOS (shiny, from repo)
  • Passes unit tests on MacOS (flight, from repo)
  • Passes unit tests on MacOS (installed into shiny, tested installed version)
  • [N/A] Functional testing

@taldcroft taldcroft changed the title Remove all dependencies on Chandra.cmd_states and Ska.ParseCM SHINY: remove all dependencies on Chandra.cmd_states and Ska.ParseCM Jun 26, 2020
@taldcroft taldcroft requested a review from jeanconn June 28, 2020 20:40
@taldcroft taldcroft changed the base branch from master to shiny June 30, 2020 14:05
@taldcroft taldcroft merged commit 7794f88 into shiny Jun 30, 2020
@taldcroft taldcroft deleted the remove-chandra-cmd-states branch June 30, 2020 18:01
@javierggt javierggt mentioned this pull request Nov 17, 2020
Merged
@javierggt javierggt mentioned this pull request Dec 7, 2020
Merged
@javierggt javierggt mentioned this pull request Apr 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanconn jeanconn Awaiting requested review from jeanconn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@taldcroft
0