Refresh regression testing and fix ruff / improve variable naming #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 13 changed files in this pull request and generated no suggestions.
Files not reviewed (8)
- NOTES/NOTES.test: Language not supported
- make_test_eng_archive.csh: Language not supported
- make_test_eng_archive.sh: Language not supported
- pyrightconfig.json: Language not supported
- regression_test_eng_archive.sh: Language not supported
- .pre-commit-config.yaml: Evaluated as low risk
- cheta/tests/test_orbit.py: Evaluated as low risk
- cheta/update_archive.py: Evaluated as low risk
Comments skipped due to low confidence (1)
test/make_plots.py:4
- The comment should be 'sanity check' instead of 'sanity check'.
# Make a few plots for a sanity check of test archive correctness
jeanconn
approved these changes
Nov 29, 2024
This was referenced Dec 9, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refreshes the basic regression testing of
cheta/update_archive.pywhich is run on HEAD. The existing scripts and documentation were out of date, including several that only existed as legacy Python 2 scripts. The initial driver was to test ruff updates to that module, but having functional regression testing is independently important.This also fixes a few ruff warnings. While in the code, I took the opportunity to document a couple of key functions and use modern standards for naming variables. The renaming was done using VS code so there is high confidence in correctness. Nevertheless there is no coverage of these changes in unit tests so I will run the manual regression testing procedure.
This should have been two PR's but that isn't the way things happened...
Interface impacts
None
Testing
Unit tests
Independent check of unit tests by Jean
Functional tests
Regression testing on HEAD by using the script
regression_test_eng_archive.sh:test/compare_regr_vals.py) all OK.