8000 Add module to allow getting model spec files from Ska data by taldcroft · Pull Request #96 · sot/xija · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add module to allow getting model spec files from Ska data #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 16, 2020
Merged

Add module to allow getting model spec files from Ska data #96

merged 9 commits into from
Oct 16, 2020

Conversation

taldcroft
Copy link
Member
@taldcroft taldcroft commented Sep 30, 2020 •
edited
Loading

Description

This adds functions that allow reliably getting xija model spec files from $SKA/data/chandra_models.

By "reliable", the intent is that this will be used in production load review code, replacing the current practice of embedding the spec files into load review code.

The key benefit is allowing more agile xija model updates without requiring code updates and a full Ska3 release. The concept of allowing xija model updates without a code release has been put into practice for MATLAB tools, so extending this to SOT tools seems natural.

Along with this we need the following:

  • Clone of the latest flight-approved models git repository in $SKA/data/chandra_models
  • Process to keep this repo up to date. This can be a manual process that is documented in the Xija model update procedure on the TWG TWiki. E.g. a Ska admin will keep this checked out at the latest release tag (which by virtue of the model update process guarantees the latest approved flight models).
  • Functionality to verify the integrity (repo is clean and at the release tag). This is in the current module.

Testing

  • Passes unit tests on MacOS
  • Functional testing (new tests)

@taldcroft taldcroft changed the title WIP: add module to allow getting model spec files from Ska data Add module to allow getting model spec files from Ska data Oct 2, 2020
@taldcroft taldcroft mentioned this pull request Oct 2, 2020
Merged
1 task
@taldcroft taldcroft requested a review from jeanconn October 5, 2020 13:53
jeanconn
jeanconn reviewed Oct 12, 2020
View reviewed changes
@taldcroft taldcroft merged commit 1feae17 into master Oct 16, 2020
@taldcroft taldcroft deleted the get-model-spec branch October 16, 2020 19:39
@javierggt javierggt mentioned this pull request Nov 17, 2020
Merged
@javierggt javierggt mentioned this pull request Dec 7, 2020
Merged
@javierggt javierggt mentioned this pull request Jan 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanconn jeanconn jeanconn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taldcroft @jeanconn
0