Use github's 'latest' release link for latest version #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of fetching all the releases on chandra_models release page, use github's idea of the 'latest' one.
I've already forgotten if we're run into issues with this that could be a problem for chandra_models, but at least it doesn't include pre-releases (which aren't a great conceptual fit with the checks in xija.get_model_spec).
We could probably also filter the old list or some such, but for the given use case, this made sense to me, and maybe it is helpful.
Testing
TA: I tried this in my repo after reverting my $SKA/data/chandra_models to 3.32 and it passed tests.