8000 Support running with no --test-spec by taldcroft · Pull Request #24 · sot/testr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support running with no --test-spec #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2020
Merged

Support running with no --test-spec #24

merged 1 commit into from
Jul 24, 2020

Conversation

taldcroft
Copy link
Member
@taldcroft taldcroft commented Jul 24, 2020 •
edited
Loading

Description

Looks like an order mix-up in coercing opt.test_spec to string for serialization.

Testing

  • [N/A] Passes unit tests (no tests)
  • Functional testing

Ran env PYTHONPATH=$PWD run_testr --include agasc --root ~/git/ska_testr within testr git repo and confirm that run succeeded and that the output in outputs/logs/last/all_tests.json is expected:

...
    "ska_version": "e18efa3",
    "test_spec": "None",
    "t_stop": "2020:07:24T09:21:34",
    "t_start": "2020:07:24T09:21:26",
...

@taldcroft taldcroft requested a review from javierggt July 24, 2020 13:25
@taldcroft taldcroft merged commit 09fc6db into master Jul 24, 2020
@taldcroft taldcroft deleted the no-test-spec branch July 24, 2020 22:06
@javierggt javierggt mentioned this pull request Nov 17, 2020
Merged
@javierggt javierggt mentioned this pull request Dec 7, 2020
Merged
@javierggt javierggt mentioned this pull request May 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierggt javierggt javierggt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taldcroft @javierggt
0