Fix return type for Regexp::last_match
#3331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
ec099cb to
b4ae75c
Compare
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
|
While at it, it seems the argument can also be a |
|
We have a policy of testing changes to Sorbet against Stripe's codebase before Stripe employees can see the build result here: |
marianosimone
approved these changes
Aug 5, 2020
paracycle
reviewed
Aug 13, 2020
| @@ -869,12 +869,12 @@ class Regexp < Object | |||
| # Regexp.last_match(:lhs) #=> "var" | |||
| # Regexp.last_match(:rhs) #=> "val" | |||
| # ``` | |||
| sig {returns(MatchData)} | |||
| sig {returns(T.nilable(MatchData))} | |||
There was a problem hiding this comment.
I think the method always returns a MatchData object in this form, so this should not have been made nilable.
There was a problem hiding this comment.
It is possible for it to return nil, when you haven't tried to match anything before:
irb(main):002:0> Regexp.last_match
=> nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As shown in the documentation a few lines above, the return type of
Regexp::last_matchcan benil:Test plan
See included automated tests.
cc. @paracycle @seachel