8000 Import signatures for resolv.rbi from sorbet-typed by Morriar · Pull Request #3150 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Import signatures for resolv.rbi from sorbet-typed #3150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2020
Merged

Import signatures for resolv.rbi from sorbet-typed #3150

merged 1 commit into from
Jun 8, 2020

Conversation

Morriar
Copy link
Collaborator
@Morriar Morriar commented Jun 4, 2020

Motivation

Now that resolv.rbi is in the payload, this PR imports all the signatures from sorbet-typed.

Test plan

See included automated tests.

@Morriar
Import signatures for resolv.rbi from sorbet-typed
1dd7996 
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar requested a review from a team as a code owner June 4, 2020 15:53
@Morriar Morriar requested review from elliottt and removed request for a team June 4, 2020 15:53
@Morriar Morriar mentioned this pull request Jun 4, 2020
Merged
@elliottt
Copy link
Collaborator
elliottt commented Jun 4, 2020

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR. When the build
finishes, I'll share with you whether or how it failed. Thanks!

Stripe employees can see the build result here:

→ https://go/builds/bui_HPDYMnhkJ39vxf

elliottt
elliottt approved these changes Jun 4, 2020
View reviewed changes
Copy link
Collaborator
@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This raised some errors on stripe's codebase, so it'll need some additional work to land. I'll take it from here, thank you!

@elliottt elliottt self-assigned this Jun 6, 2020
@elliottt
Copy link
Collaborator
elliottt commented Jun 8, 2020

Fixed issues in https://go/ps/pull/239916

@elliottt elliottt merged commit 8cd823a into sorbet:master Jun 8, 2020
@Morriar Morriar deleted the at-rbi-resolv branch July 26, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliottt elliottt elliottt approved these changes

Assignees

@elliottt elliottt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Morriar @elliottt
0