Preserve the generated error class on serialize #3146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do some fancy wrapping logic that tries to provide more context on where the error message came from when it came from the generated serialize, probably because the line numbers look terrible with the module_eval tricks we're doing. The problem is that this means sometimes the error kind can change depending on the order the code loads. The change to the test exemplifies this. We swallowed a NoMethodError and converted it to a TypeError.
elliottt
approved these changes
Jun 4, 2020
|
This changes some behavior on Stripe's codebase: https://go/builds/bui_HOwAibuRsofU7Q but i consider all the changes good changes. I'll address them before landing this. |
|
Do we want to be paranoid about the possibility of exception classes that don't have a single-argument constructor accepting a string? |
@djudd-stripe I thought about that. Do you have a suggestion for how we could do it? |
|
@jez I think the most robust way would be to do something like Hideous but maybe the right thing to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We do some fancy wrapping logic that tries to provide more context on
where the error message came from when it came from the generated
serialize, probably because the line numbers look terrible with the
module_eval tricks we're doing.
The problem is that this means sometimes the error kind can change
depending on the order the code loads.
The change to the test exemplifies this. We swallowed a NoMethodError
and converted it to a TypeError.
Test plan
See included automated tests.