8000 Mark Struct bodies as currently unimplemented by jez · Pull Request #3108 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Mark Struct bodies as currently unimplemented #3108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2020
Merged

Mark Struct bodies as currently unimplemented #3108

merged 2 commits into from
May 28, 2020

Conversation

jez
Copy link
Collaborator
@jez jez commented May 28, 2020

Motivation

The generated bodies were previously garbage.

Test plan

See included automated tests.

@jez jez requested a review from a team as a code owner May 28, 2020 22:18
@jez jez requested review from elliottt and removed request for a team May 28, 2020 22:18
@jez
Mark Struct bodies as currently unimplemented
7feeffb 
The generated bodies were previously garbage.
@jez jez force-pushed the jez-struct-raise branch from c60ac8f to 9994053 Compare May 28, 2020 22:22
@jez jez force-pushed the jez-struct-raise branch from 9994053 to b165316 Compare May 28, 2020 22:32
@jez jez merged commit a25ac19 into master May 28, 2020
@jez jez deleted the jez-struct-raise branch May 28, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliottt elliottt elliottt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jez @elliottt
0