8000 Add quick note about Locs to internals.md by jez · Pull Request #3105 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add quick note about Locs to internals.md #3105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2020
Merged

Add quick note about Locs to internals.md #3105

merged 1 commit into from
May 28, 2020

Conversation

jez
Copy link
Collaborator
@jez jez commented May 28, 2020

Motivation

Someone asked yesterday.

Test plan

See included automated tests.

@jez jez requested a review from a team as a code owner May 28, 2020 21:27
< 8000 /div>
@jez jez requested review from elliottt and removed request for a team May 28, 2020 21:27
elliottt
elliottt approved these changes May 28, 2020
View reviewed changes
Copy link
Collaborator
@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it's worth clarifying what's meant by best?

@jez
Copy link
Collaborator Author
jez commented May 28, 2020

Do you think it's worth clarifying what's meant by best?

Absolutely, but this section is unfinished. At this point it's just a list of reminders for what to talk about if we made a whole section about Loc. And it might be the case that we should document this in comments and just link to it from internals.

@jez jez merged commit 12c2914 into master May 28, 2020
@jez jez deleted the jez-loc branch May 28, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliottt elliottt elliottt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jez @elliottt
0