Add -isystem on macOS Catalina to fix ruby build #3062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This manifested as an error that looked like:
command ./configure --enable-load-relative --with-destdir=/private/var/tmp/_bazel_jez/491a13d243378e23690a7f8390a5c09f/sandbox/darwin-sandbox/2/execroot/com_stripe_ruby_typer/bazel-out/darwin-fastbuild/bin/external/ruby_2_6/toolchain --with-rubyhdrdir=${includedir} --with-rubyarchhdrdir=${includedir}/ruby-arch --disable-install-doc --prefix=/ failed!
checking for ruby... /usr/bin/ruby
tool/config.guess already exists
tool/config.sub already exists
checking build system type... x86_64-apple-darwin19.3.0
checking host system type... x86_64-apple-darwin19.3.0
checking target system type... x86_64-apple-darwin19.3.0
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... configure: error: in `/var/folders/5p/z_n7b95s1yz02fdjwvk8cwp80000gn/T/tmp.FpE76u33':
configure: error: cannot run C compiled programs.
If you meant to cross compile, use `--host'.
See `config.log' for more details
build dir: /var/folders/5p/z_n7b95s1yz02fdjwvk8cwp80000gn/T/tmp.FpE76u33
Target @ruby_2_6//:ruby failed to build
elliottt
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This manifested as an error that looked like:
cc @Morriar @jvilk-stripe this should fix the errors you were seeing trying to
build
@ruby_2_6locally.https://stackoverflow.com/questions/58278260/cant-compile-a-c-program-on-a-mac-after-upgrading-to-catalina-10-15/58278392#58278392
Test plan
Tested in my personal laptop running macOS Catalina, and also on my work laptop
running macOS Mojave.