10000 Add missing definitions in stdlib/net by Morriar · Pull Request #3055 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add missing definitions in stdlib/net #3055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add missing definitions in stdlib/net #3055

wants to merge 1 commit into from

Conversation

Morriar
Copy link
Collaborator
@Morriar Morriar commented May 19, 2020

No signatures.

@Morriar Morriar requested a review from a team as a code owner May 19, 2020 16:51
@Morriar Morriar requested review from jez and removed request for a team May 19, 2020 16:51
@jez
< 8000 /svg> Copy link
Collaborator
jez commented May 20, 2020

Testing on Stripe's codebase:

http://go/builds/bui_HJXfCFdsFhFyse

jez
jez requested changes May 20, 2020
View reviewed changes
Copy link
Collaborator
@jez jez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stripe's CI passes but Sorbet's CI is failing (check buildkite).

Happy to re-review when it's passing.

@Morriar
Add missing definitions in stdlib/net
4894647 
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar
Copy link
Collaborator Author
Morriar commented May 28, 2020

^ fixed tests

@jez
Copy link
Collaborator
jez commented May 28, 2020

@Morriar I included most of these in #3109, so I think i'm going to close this unless you had any opinions otherwise.

@Morriar
Copy link
Collaborator Author
Morriar commented May 29, 2020

Thanks! Closing.

@Morriar Morriar closed this May 29, 2020
@Morriar Morriar deleted the at-rbi-net branch June 4, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jez jez jez requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Morriar @jez
0