Replace fmt with rapidjson in tracing.cc #2855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that all of the JSON is properly escaped, even in the presence of UTF-8 non-ASCII characters in the strings.
jez
commented
Apr 7, 2020
| # We used to essentially have something like this at Stripe, | ||
| # and it would crash us when trying to serialize a web trace file | ||
| # (because the method name was in one of the args) | ||
| it '’' do |
There was a problem hiding this comment.
I verified that this test failed here:
https://buildkite.com/sorbet/sorbet/builds/9847#1e9ff4d8-51c2-418c-bcab-eca775822355
elliottt
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This ensures that all of the JSON is properly escaped, even in the presence
of UTF-8 non-ASCII characters in the strings.
Test plan
See included automated tests.