IDE: Operation-specific metrics and small improvements #2500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pecific timer. Used to measure the latency of specific operations.
mkillianey-stripe
approved these changes
Jan 17, 2020
main/lsp/LSPMessage.cc
Outdated
8000
| void LSPMessage::cancel() { | ||
| if (!canceled) { | ||
| canceled = true; | ||
| // Protect against nullptrs. |
There was a problem hiding this comment.
Personal preference nit: although I'm generally in favor of more comments, this specific one didn't give me any extra information that wasn't clear to me from the code. (I see that this code moved, and the original had this comment, so just giving you the liberty to remove if you found it equally tame.)
There was a problem hiding this comment.
Ah, I can add context: A Timer may not be specified (it's optional).
|
why is this requesting extra reviews? sorry about that |
|
I think dmitry changed some things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDE: Operation-specific metrics and small improvements
Specific changes:
LSPMessages now have a second optional timer that tracks the latency of specific methods.LSPMessagenow contains message (and timer) cancelation logic.enableMultithreadingis now a property ofLSPTaskrather than a parameter toTypecheckerCoordinator::syncRun.TypecheckerTask::hasDedicatedThreadtoTypecheckerTask::collectCounters.Motivation
We have no way to check the latency of specific operations in SignalFX, as all operations are grouped together
Test plan
See included automated tests.