8000 Raise errors about bad `test_each` arity by aisamanra · Pull Request #2495 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Raise errors about bad test_each arity #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 16, 2020
Merged

Raise errors about bad test_each arity #2495

merged 3 commits into from
Jan 16, 2020

Conversation

aisamanra
Copy link
Contributor

Motivation

This would just confusingly not work before, but now this produces an error when you use test_each with more than one parameter to the proc.

Test plan

See included automated tests.

@aisamanra aisamanra requested a review from a team January 16, 2020 01:42
@mergify mergify bot merged commit 3bad219 into master Jan 16, 2020
@jez jez deleted the gdritter/test-each-arity branch December 20, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jez jez jez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aisamanra @jez
0