8000 Add FrozenError by aisamanra · Pull Request #2319 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add FrozenError #2319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 9, 2019
Merged

Add FrozenError #2319

merged 2 commits into from
Dec 9, 2019

Conversation

aisamanra
Copy link
Contributor

Motivation

Fixes #2317. Had to re-run the missing method tests, 'cause FrozenError is no longer missing.

Test plan

See included automated tests.

@aisamanra aisamanra requested a review from a team December 9, 2019 17:41
@ghost ghost requested review from DarkDimius and removed request for a team December 9, 2019 17:41
@aisamanra aisamanra requested a review from elliottt December 9, 2019 17:49
elliottt
elliottt approved these changes Dec 9, 2019
View reviewed changes
Copy link
Collaborator
@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aisamanra aisamanra merged commit 8f00b19 into master Dec 9, 2019
@jez jez deleted the gdritter/add-frozenerror branch December 20, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliottt elliottt elliottt approved these changes

@DarkDimius DarkDimius Awaiting requested review from DarkDimius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sorbet doesn't recognize FrozenError
2 participants
@aisamanra @elliottt
0