8000 Fix publish-ruby-gems.sh by fzakaria · Pull Request #2305 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix publish-ruby-gems.sh #2305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Conversation

fzakaria
Copy link
Contributor
@fzakaria fzakaria commented Dec 6, 2019

This is a fix ontop of #2298 which changed slightly publish-ruby-gems.sh
The Darwin platform is the only gem with multiple files, so changed the
publishing code to be explicit.

The benefit of this approach to the previous glob file approach, is that
the version can be checked for each platform number (i.e.
universal-darwin-18) if it has been published before.

This is a fix ontop of sorbet#2298 which changed slightly `publish-ruby-gems.sh`
The Darwin platform is the only gem with multiple files, so changed the
publishing code to be explicit.

The benefit of this approach to the previous glob file approach, is that
the version can be checked for each platform number (i.e.
universal-darwin-18) if it has been published before.
@fzakaria fzakaria requested a review from a team December 6, 2019 16:41
@ghost ghost requested review from elliottt and removed request for a team December 6, 2019 16:41
@fzakaria
Copy link
Contributor Author
fzakaria commented Dec 6, 2019

CC @DarkDimius @ptarjan who have been working with me on these changes.

Once this lands -- may we run the publish ruby gems step manually to verify?

@ptarjan ptarjan added the mergify label Dec 6, 2019
@ptarjan
Copy link
Contributor
ptarjan commented Dec 6, 2019

Once this lands -- may we run the publish ruby gems step manually to verify?

Yup, I will do it. Ping me if I forget.

@mergify mergify bot merged commit 0549d84 into sorbet:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0