10000 return T.untyped from `self.class` by ptarjan · Pull Request #1055 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

return T.untyped from self.class #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 25, 2019
Merged

return T.untyped from self.class #1055

merged 2 commits into from
Jun 25, 2019

Conversation

ptarjan
Copy link
Contributor
@ptarjan ptarjan commented Jun 25, 2019

Motivation

I think this might have been why we didn't have it? I tried bumping this in pay-server and 63 of the callers seemed like they wanted methods on the Class. If I made it return something dumb like Integer I got 147 errors. Is that high enough of a caller % to go to untyped?

Test plan

See included automated tests.

@ptarjan ptarjan requested review from DarkDimius and a team June 25, 2019 22:40
@ghost ghost removed their request for review June 25, 2019 22:40
jez
jez approved these changes Jun 25, 2019
View reviewed changes
Copy link
Collaborator
@jez jez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this. I'll let the first person who complains be the one to fix it.

@ptarjan ptarjan merged commit 2179569 into master Jun 25, 2019
@ptarjan ptarjan deleted the pt-kernel-looser branch June 25, 2019 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jez jez jez approved these changes

@DarkDimius DarkDimius Awaiting requested review from DarkDimius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptarjan @jez
0