8000 only suggest including modules by ptarjan · Pull Request #1047 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

only suggest including modules #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2019
Merged

only suggest including modules #1047

merged 1 commit into from
Jun 25, 2019

Conversation

ptarjan
Copy link
Contributor
@ptarjan ptarjan commented Jun 25, 2019

Came up in a StackOverflow

Motivation

Test plan

See included automated tests.

@ptarjan ptarjan requested a review from a team June 25, 2019 17:30
@ghost ghost requested review from jez and removed request for a team June 25, 2019 17:30
jez
jez approved these changes Jun 25, 2019
View reviewed changes
Copy link
Collaborator
@jez jez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isClassModule is a slightly non-intuitive name but makes sense after looking at it

@jez jez merged commit ea80b04 into master Jun 25, 2019
@jez jez deleted the pt-include-message branch June 25, 2019 17:59
@mvidner
Copy link
Contributor
mvidner commented Jun 26, 2019

For reference, this was the SO question: https://stackoverflow.com/questions/56758793/how-to-call-self-class-from-a-mix-in-module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jez jez jez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ptarjan @mvidner @jez
0