Rename DANGER_enable_checking_in_tests #1039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkDimius
approved these changes
Jun 25, 2019
This moves `T::Utils.DANGER_enable_checking_in_tests` to `T::Configuration.enable_checking_for_sigs_marked_checked_tests`. I'm happy to drop the `!`. I only added it because it used to say `DANGER`. Moving to `T::Configuration` is the only change I care about. This is on the blocking path to re-enabling soft / checked / generated in open-source.
90bdeb3 to
b549952
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<
29D6
span class="js-suggested-changes-inline-error-message position-relative error m-0" style="max-width: inherit;">
This moves
T::Utils.DANGER_enable_checking_in_teststoT::Configuration.enable_checking_for_checked_tests_sigs!.I'm happy to drop the
!. I only added it because it used to sayDANGER. Moving toT::Configurationis the only change I care about.Motivation
This is on the blocking path to re-enabling soft / checked / generated
in open-source.
Test plan
See included automated tests.