Changes for #979 - Document Prereq's #1007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes for sorbet#979
jez
reviewed
Jun 22, 2019
README.md
Outdated
|
|
||
| #### Windows: We do not work on Windows so we do not have test | ||
| experience on this platform. We welcome community help with this. | ||
|
|
There was a problem hiding this comment.
The README is intended for contributors, but you documented things from the perspective of a Sorbet user.
The project prerequisites for building Sorbet are already documented in the Quickstart section of the README.
We use sorbet.org to document things that users would like to know about Sorbet. I've moved these changes to the FAQ.
jez
approved these changes
8000
Jun 22, 2019
|
@jez - Thanks - reason I did not select FAQ was the other FAQ item were language-specific, not environment. Fine with it in FAQ. Thanks again. |
|
@jasnow thank you for your contribution! |
|
@jez - You might want to specify which Ruby, such as Ruby MRI, in the FAQ. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for #979: Document Prereq's
Motivation
Test plan
See included automated tests.