suggest no-config #994
Merged
suggest no-config #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkDimius
approved these changes
Jun 21, 2019
jez
reviewed
Jun 21, 2019
| @@ -114,7 +114,7 @@ def write_constants | |||
| ) | |||
| File.write(SOURCE_CONSTANTS, io.read) | |||
| io.close | |||
| raise "Your source can't be read by Sorbet.\nYou can try `rm sorbet/config; find . -type f | xargs -L 1 -t srb tc --error-white-list 1000` and hopefully the last file it is processing before it dies is the culprit.\nIf not, maybe the errors in this file will help: #{SOURCE_CONSTANTS_ERR}" if File.read(SOURCE_CONSTANTS).empty? | |||
| raise "Your source can't be read by Sorbet.\nYou can try `find . -type f | xargs -L 1 -t srb tc --no-config --error-white-list 1000` and hopefully the last file it is processing before it dies is the culprit.\nIf not, maybe the errors in this file will help: #{SOURCE_CONSTANTS_ERR}" if File.read(SOURCE_CONSTANTS).empty? | |||
|
|
|||
| puts "Printing #{TMP_RBI}'s symbol table into #{RBI_CONSTANTS}" | |||
| # Change dir to deal with you having a sorbet/config in your cwd | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Test plan
See included automated tests.