Desugar multiple assignment such that it returns rhs #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not being faithful to what Ruby does with our multiple
assignment desugar. We were returning the result of a call to our magic
expand splat method which is almost always not what actually happens at
runtime.
Here is the result of the attached test case before this commit:
```ruby
extend T::Sig
sig {returns(T.nilable(T::Array[Integer]))}
def foo
nil
end
T.reveal_type((a, b = foo)) # Revealed type: T.any(T::Array[Integer], [NilClass, NilClass])
T.reveal_type((c, *, d = 100)) # Revealed type: [Integer(100), NilClass] (2-tuple)
```
DarkDimius
reviewed
Jun 21, 2019
Ah sorry I missed it in the scroll back. It's there thank you. |
jez
reviewed
Jun 21, 2019
jez
reviewed
Jun 21, 2019
jez
approved these changes
Jun 21, 2019
Co-Authored-By: Jake Zimmerman <zimmerman.jake@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not being faithful to what Ruby does with our multiple
assignment desugar. We were returning the result of a call to our magic
expand splat method which is almost always not what actually happens at
runtime.
Here is the result of the attached test case before this commit:
Motivation
Fix #981 and be more faithful.
Test plan
See included automated tests.