Make Sorbet faster to start in debug build #8050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are all hot for the sake of reading the initial GlobalState, and are all ~trivial integer or boolean operations that should never take a long time (vs something like an `absl::c_count` that maps a function over a vector to compute a property).
In `--config=dbg` we don't necessarily get optimizations that would remove this check. I want to make sure it gets removed and that's easy with `constexpr`.
neilparikh
requested changes
Jul 24, 2024
|
|
||
| sanityCheckTableSizes(); | ||
| sanityCheckNames(); | ||
|
|
||
| { | ||
| Timer timeit(tracer(), "GlobalState::sanityCheck (symbols)"); |
There was a problem hiding this comment.
Any reason not to split this off into sanityCheckSymbols? Do we always want to also do sanityCheckTableSizes and sanityCheckNames when this is done?
There was a problem hiding this comment.
I'm not quite sure what you're asking.
There were some places where I only wanted to sanity check the table sizes, or sanity check the names, so I factored out helpers for these.
There were no places where I only wanted to sanity check the symbols, so I did not factor them out of the top-level sanity check function.
There was a problem hiding this comment.
Ah, that answers exactly what I was asking, thanks.
neilparikh
approved these changes
Jul 24, 2024
jez
added a commit
that referenced
this pull request
Jul 29, 2024
This reverts commit 5101acf. Somehow this caused CI to become flaky?
jez
added a commit
that referenced
this pull request
Jul 29, 2024
jez
added a commit
that referenced
this pull request
Jul 31, 2024
* Add timers to GlobalState::sanityCheck
* ENFORCE -> ENFORCE_NO_TIMER in a lot of hot places
These are all hot for the sake of reading the initial GlobalState, and
are all ~trivial integer or boolean operations that should never take a
long time (vs something like an `absl::c_count` that maps a function
over a vector to compute a property).
* Use `constexpr` for `fuzz_mode` and `debug_mode`
In `--config=dbg` we don't necessarily get optimizations that would
remove this check. I want to make sure it gets removed and that's easy
with `constexpr`.
fastmod 'if \(fuzz_mode\)' 'if constexpr (fuzz_mode)'
fastmod 'if \((!?)debug_mode\)' 'if constexpr (${1}debug_mode)'
tools/scripts/format_cxx.sh
* Remove some counters that are not that useful
* Factor out sanityCheckTableSizes function
* Factor out sanityCheckNames function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It had been starting to annoy me how long it would take to start Sorbet in debug
mode, so I went and profiled it and culled the biggest offenders.
Test plan
Existing tests