8000 delete isAttrReader by neilparikh · Pull Request #8039 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

delete isAttrReader #8039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 18, 2024
Merged

delete isAttrReader #8039

merged 4 commits into from
Jul 18, 2024

Conversation

neilparikh
Copy link
Collaborator

Motivation

Compiler is deleted.

Test plan

Existing tests.

@neilparikh neilparikh force-pushed the neil-delete-isAttrReader branch from eaf845b to 460a4d2 Compare July 18, 2024 01:05
@neilparikh
Copy link
Collaborator Author

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR. When the build
finishes, I'll share with you whether or how it failed. Thanks!

Stripe employees can see the build results here:

→ https://go/builds/bui_QUiYchnbwW63Q5
→ https://go/builds/bui_QUiY3FrvkSJTAw
→ https://go/builds/bui_QUiY65DiLWyvYv

@neilparikh neilparikh force-pushed the neil-delete-isAttrReader branch from 172d3ec to 1d3e69c Compare July 18, 2024 18:10
@neilparikh
delete compiled: true
4d7a36d
@neilparikh
Delete these tests
7e07d10 
They're now the same as the non compiled version.
@neilparikh neilparikh force-pushed the neil-delete-isAttrReader branch from 09448ce to 7e07d10 Compare July 18, 2024 18:52
@neilparikh neilparikh marked this pull request as ready for review July 18, 2024 18:53
@neilparikh neilparikh requested a review from a team as a code owner July 18, 2024 18:53
@neilparikh neilparikh requested review from jez and removed request for a team July 18, 2024 18:53
jez
jez approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator
@jez jez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find

@neilparikh neilparikh merged commit cfb9dfe into master Jul 18, 2024
16 checks passed
@neilparikh neilparikh deleted the neil-delete-isAttrReader branch July 18, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jez jez jez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neilparikh @jez
0