Hide Hash::Elem in detailed type errors #8038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilparikh
approved these changes
Jul 19, 2024
| joiningText = "a supertype of"; | ||
| break; | ||
| if (!(a2->klass == Symbols::Hash() && | ||
| idxTypeMember.data(gs)->name == core::Names::Constants::Elem())) { |
There was a problem hiding this comment.
I think you can flip the condition and then do a early break here, to avoid the additional nesting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Two types disagreeing for the type of
Hash::Elemis always noise, becauseSorbet creates this type implicitly when constructing a hash. It behaves as if
it has the type
[Hash::K, Hash::V] (2-tuple)for all hashes.Test plan
See included automated tests.