8000 Add special message for `Struct` methods w/o sigs by jez · Pull Request #6514 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add special message for Struct methods w/o sigs #6514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 2, 2022
Merged

Add special message for Struct methods w/o sigs #6514

merged 4 commits into from
Nov 2, 2022

Conversation

jez
Copy link
Collaborator
@jez jez commented Oct 27, 2022

Motivation

Avoid confusion from inexperienced Sorbet users.

Test plan

See included automated tests.

@jez jez requested a review from a team as a code owner October 27, 2022 21:59
@jez jez requested review from froydnj and removed request for a team October 27, 2022 21:59
Copy link
Contributor
@froydnj froydnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, sorry for forgetting about this one. :(

@jez
Copy link
Collaborator Author
jez commented Nov 2, 2022

No worries, I forgot about it too.

@jez jez merged commit 9a9007d into master Nov 2, 2022
@jez jez deleted the jez-struct-sig branch November 2, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0