8000 Update T::Struct docs by jez · Pull Request #6502 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update T::Struct docs #6502

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2022
Merged

Update T::Struct docs #6502

merged 2 commits into from
Oct 25, 2022

Conversation

jez
Copy link
Collaborator
@jez jez commented Oct 23, 2022

Motivation

This started out as a set of suggestions to make to #6462, but grew into
something larger, so I opened a new PR.

Closes #6462.

Test plan

website-only change.

@jez jez requested a review from a team as a code owner October 23, 2022 03:42
@jez jez requested review from froydnj and removed request for a team October 23, 2022 03:42
@jez jez mentioned this pull request Oct 23, 2022
Closed
bdewater
bdewater approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor
@bdewater bdewater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for rewriting - I had no idea about the historical context. Looks great, only a couple of questions on a few things that didn't make the cut from my proposal.

@jez jez requested a review from ilyailya October 25, 2022 00:00
ilyailya
ilyailya approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor
@ilyailya ilyailya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jez jez merged commit 9a24671 into master Oct 25, 2022
@jez jez deleted the jez-struct-docs branch October 25, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdewater bdewater bdewater approved these changes

@ilyailya ilyailya ilyailya approved these changes

@froydnj froydnj Awaiting requested review from froydnj froydnj is a code owner automatically assigned from sorbet/core-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jez @bdewater @ilyailya
0