Revert "update vscode-languageclient with LSP 3.17 support (#6492)" #6501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dbe0dca.
jez
approved these changes
Oct 21, 2022
damolina-stripe
added a commit
that referenced
this pull request
Feb 28, 2025
Upgrade LanguageClient to 8.1.0 - Update code to use `start` instead of `onReady`: this is not a trivial as it sounds as behaviors changed slightly, particularly in regards to error handling. - Adding `initializationFailedHandler` to the `LanguageClient` created by `createClient` so preexisting connection errors (e.g. `Pending response rejected since connection got disposed`) do not surface as notifications (chane introduced in LC 3.17). - Wrapping the `LanguageClient` created by `createClient` with an implementation that overrides `error` to override the `force` flag that causes some errors to bubble up. There were and are ongoing reports about this: 8.0 allowed errors to bubble up which exposed the issues with `force`, and `8.1.0` fix some, but not all issues (and still there as of latest version on 2/28/2025). Misc: - Move `SorbetLanguageClient` to `sorbetLanguageClient.ts` to match class name. - `languageClient.ts`, next to `languageClient.metrics.ts` operate on `LanguageClient`. Conviniently, existing `languageClient.test.ts` matches this separation. References - Previous attempt: Revert "update vscode-languageclient with LSP 3.17 support (#6492)" #6501 - Relevant spec changes: - `onReady` removed: [3.17.0](https://github.com/microsoft/vscode-languageserver-node/blob/main/README.md#3170-protocol-800-json-rpc-800-client-and-800-server) - Updates to error handling (required but not enough to limit spurious errors from showing as notifications, unless handled) : [3.17.3](https://github.com/microsoft/vscode-languageserver-node/blob/main/README.md#3173-protocol-810-json-rpc-810-client-and-810-server)
damolina-stripe
added a commit
that referenced
this pull request
Mar 3, 2025
* Upgrade LanguageClient to 8.1.0 Upgrade LanguageClient to 8.1.0 - Update code to use `start` instead of `onReady`: this is not a trivial as it sounds as behaviors changed slightly, particularly in regards to error handling. - Adding `initializationFailedHandler` to the `LanguageClient` created by `createClient` so preexisting connection errors (e.g. `Pending response rejected since connection got disposed`) do not surface as notifications (chane introduced in LC 3.17). - Wrapping the `LanguageClient` created by `createClient` with an implementation that overrides `error` to override the `force` flag that causes some errors to bubble up. There were and are ongoing reports about this: 8.0 allowed errors to bubble up which exposed the issues with `force`, and `8.1.0` fix some, but not all issues (and still there as of latest version on 2/28/2025). Misc: - Move `SorbetLanguageClient` to `sorbetLanguageClient.ts` to match class name. - `languageClient.ts`, next to `languageClient.metrics.ts` operate on `LanguageClient`. Conviniently, existing `languageClient.test.ts` matches this separation. References - Previous attempt: Revert "update vscode-languageclient with LSP 3.17 support (#6492)" #6501 - Relevant spec changes: - `onReady` removed: [3.17.0](https://github.com/microsoft/vscode-languageserver-node/blob/main/README.md#3170-protocol-800-json-rpc-800-client-and-800-server) - Updates to error handling (required but not enough to limit spurious errors from showing as notifications, unless handled) : [3.17.3](https://github.com/microsoft/vscode-languageserver-node/blob/main/README.md#3173-protocol-810-json-rpc-810-client-and-810-server) * Allow DISABLED > INITIALZING transition: we should start in the former state now since initialization does not really start until `start` is invoked. Set `activeLanguageClient` before `start` because components will query the client for state, in particular, the statusbar item * Set `RUNNING` after `start` has completed. Also, to make easier to think about the scenario move setting `INITIALIZING` right before instead of at `startSorbetProcess` (since it is actiona t a distance and even if correct it would have not corresponding `RUNNING`). * Fix: `initializationFailedHandler` should return `false` since we control retries (otherwise this enters a bad loop of restarts). Fix: in `start`, only set `RUNNING` if status is still `INITIALIZE`. When the Sorbet process fails to start, status might be `RESTARTING` or `ERROR` and it is not a valid/correct transition to go to `RUNNING` (even if it gets reset to proper via other events). * Add punctuation to improve log entry. * Update CHANGELOG. - Ship version 0.3.40.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We're getting reports from Stripe users where VSCode is spitting out scary-looking error messages for innocuous things. Previous versions of the extension seemed to handle these gracefully, but the upgrade to
vscode-languageclientseemingly introduces problems.Let's roll this back.
Test plan
See included automated tests.