Implement Array#dig and Hash#dig intrinsic
#6491
Conversation
|
We have a policy of testing changes to Sorbet against Stripe's codebase before Stripe employees can see the build results here: → https://go/builds/bui_Me1jkvpSlKWnlg |
|
We have a policy of testing changes to Sorbet against Stripe's codebase before Stripe employees can see the build results here: → https://go/builds/bui_Me2VK5QEWfwzBc |
| args.locs.file, // file | ||
| args.locs.call.copyWithZeroLength(), // call | ||
| args.locs.args[0].copyWithZeroLength(), // receiver | ||
| args.locs.args[0].copyWithZeroLength(), // fun |
There was a problem hiding this comment.
Isn't this just args.locs.fun? I don't know if it makes a difference whether you copyWithZeroLength(), but I think it would make things slightly more consistent to use args.locs.fun here.
There was a problem hiding this comment.
I don't think so?
opts.dig("first", "second")
^^^ fun
^^^^^^^ args[0]Having it be zero length makes it basically ignore it for most things, and use the callLoc instead, except that it's very hard to get a case where it would need to use these errors, because we know that the Array#at / Hash#[] methods always exist, so we're unlikely to need the fun locs. The most important location in practice is the basecaseArgLocs in case you try to pass 0 to a T::Hash[String, ...] or something.
| args.locs.file, // file | ||
| args.locs.args[1], // call | ||
| args.locs.receiver, // receiver | ||
| args.locs.args[1].copyWithZeroLength(), // fun |
There was a problem hiding this comment.
Also args.locs.funLoc. I guess we can use it as-is here, because the loc ought to be for dig, and that's what we're re-dispatching to?
There was a problem hiding this comment.
Again, I think this is not funLoc, due to above.
| # Shapes are bad--ideally lot of these would be errors | ||
| sig {params(opts: AShapeType).void} | ||
| def example4(opts) |
There was a problem hiding this comment.
The TODO in the corresponding exp file says we should have some tuple tests too.
Co-authored-by: Nathan Froyd <froydnj@gmail.com>
Co-authored-by: Nathan Froyd <froydnj@gmail.com>
Motivation
#6468
Test plan
See included automated tests.