10000 delete some dead forward definitions from `shared_ptr<core::Type>` days by froydnj · Pull Request #6499 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

delete some dead forward definitions from shared_ptr<core::Type> days #6499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2022
Merged

delete some dead forward definitions from shared_ptr<core::Type> days #6499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion core/Symbols.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ namespace sorbet::core {
class ClassOrModule;
class GlobalState;
struct LocalSymbolTableHashes;
class Type;
class MutableContext;
class Context;
class TypeAndOrigins;
Expand Down
1 change: 0 additions & 1 deletion core/TypePtr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
#include <memory>

namespace sorbet::core {
class Type;
class TypeConstraint;
struct DispatchResult;
struct DispatchArgs;
Expand Down
1 change: 0 additions & 1 deletion core/Types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include <string>
namespace sorbet::core {
/** Dmitry: unlike in Dotty, those types are always dealiased. For now */
class Type;
class AppliedType;
class IntrinsicMethod;
class TypeConstraint;
Expand Down
1 change: 0 additions & 1 deletion core/types/types.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
#include "core/Types.h"

// improve debugging.
template class std::shared_ptr<sorbet::core::Type>;
template class std::shared_ptr<sorbet::core::TypeConstraint>;
template class std::shared_ptr<sorbet::core::SendAndBlockLink>;
template class std::vector<sorbet::core::Loc>;
Expand Down
2 changes: 0 additions & 2 deletions infer/environment.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
#include "core/TypeErrorDiagnostics.h"
#include <algorithm> // find, remove_if

template struct std::pair<sorbet::core::LocalVariable, std::shared_ptr<sorbet::core::Type>>;

using namespace std;

namespace sorbet::infer {
Expand Down
0