8000 Add error for test_each_hash without pos hash arg by jez · Pull Request #5770 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add error for test_each_hash without pos hash arg #5770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2022
Merged

Add error for test_each_hash without pos hash arg #5770

merged 2 commits into from
May 9, 2022

Conversation

jez
Copy link
Collaborator
@jez jez commented May 9, 2022

Motivation

It was confusing that the Minitest rewriter did not fire without an error.

Test plan

See included automated tests.

@jez jez requested a review from a team as a code owner May 9, 2022 18:00
@jez jez requested review from froydnj and removed request for a team May 9, 2022 18:00
froydnj
froydnj approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor
@froydnj froydnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to make the rewriter model Ruby keyword arg passing, but this is much simpler.

@jez jez enabled auto-merge (squash) May 9, 2022 18:02
@jez jez merged commit 0bc53fc into master May 9, 2022
@jez jez deleted the jez-test-each-hash branch May 9, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froydnj froydnj froydnj approved these changes

Assignees
4998 No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jez @froydnj
0